JDK 9 RFR of JDK-8075567: Mark intermittently failuring security-libs tests

Sean Mullan sean.mullan at oracle.com
Sun Mar 22 15:04:51 UTC 2015


Looks fine to me, Joe.

--Sean

On 03/19/2015 09:12 PM, joe darcy wrote:
> Hello,
>
> Per a policy to mark intermittently failing tests (see
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-March/032383.html),
> please review the changes below to mark two security libs tests as
> failing intermittently:
>
>      sun/security/mscapi/ShortRSAKey1024.sh
>      sun/security/mscapi/SignUsingNONEwithRSA.sh
>
> To find these tests, I went through unresolved security-libs bugs
> looking for test failures that had information updated within the last
> six months or so.
>
> Please add or remove the intermittent jtreg keyword to security tests
> appropriately going forward.
>
> Also, please consider the general recommendation to rewrite shell tests
> as Java programs. The langtools team was able to remove nearly all shell
> tests in their test suite.
>
> Thanks,
>
> -Joe
>
> diff -r cd4aea326e89 test/sun/security/mscapi/ShortRSAKey1024.sh
> --- a/test/sun/security/mscapi/ShortRSAKey1024.sh    Thu Mar 19 13:18:49
> 2015 -0700
> +++ b/test/sun/security/mscapi/ShortRSAKey1024.sh    Thu Mar 19 17:59:43
> 2015 -0700
> @@ -30,6 +30,7 @@
>   # @run shell ShortRSAKey1024.sh 1024
>   # @run shell ShortRSAKey1024.sh 768
>   # @run shell ShortRSAKey1024.sh 512
> +# @key intermittent
>
>   # set a few environment variables so that the shell-script can run
> stand-alone
>   # in the source directory
> diff -r cd4aea326e89 test/sun/security/mscapi/SignUsingNONEwithRSA.sh
> --- a/test/sun/security/mscapi/SignUsingNONEwithRSA.sh    Thu Mar 19
> 13:18:49 2015 -0700
> +++ b/test/sun/security/mscapi/SignUsingNONEwithRSA.sh    Thu Mar 19
> 17:59:43 2015 -0700
> @@ -28,6 +28,7 @@
>   # @bug 6578658
>   # @run shell SignUsingNONEwithRSA.sh
>   # @summary Sign using the NONEwithRSA signature algorithm from SunMSCAPI
> +#  @key intermittent
>
>   # set a few environment variables so that the shell-script can run
> stand-alone
>   # in the source directory
>



More information about the security-dev mailing list