[9] RFR: 8079140: IgnoreAllErrorHandler should use doPrivileged when it reads system properties

Artem Smotrakov artem.smotrakov at oracle.com
Mon May 18 15:17:49 UTC 2015


Hi Sean,

Ok, I updated the webrev, please take a look:

http://cr.openjdk.java.net/~asmotrak/8079140/webrev.01/

Artem

On 05/18/2015 05:00 PM, Sean Mullan wrote:
> Hi Artem,
>
> This fix looks good but I would prefer that you did not use a lambda 
> expression for reading the system properties (lines 50-52) because 
> ideally this code needs to stay in sync with the Apache Santuario 
> implementation which still supports JDK 1.6 and up.
>
> Thanks,
> Sean
>
> On 05/15/2015 02:23 PM, Artem Smotrakov wrote:
>> Hello,
>>
>> Please review this fix for 9.
>>
>> If security manager is enabled, but "org.jcp.xml.dsig.secureValidation"
>> property is off, IgnoreAllErrorHandler tries to read two system
>> properties. If appropriate permissions are not granted, it fails with
>> ExceptionInInitializerError.
>>
>> Changes:
>> - updated IgnoreAllErrorHandler to read system properties in
>> doPrivileged() method
>> - added "final" and @Override annotations
>> - added ErrorHandlerPermissions test
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8079140
>> Webrev: http://cr.openjdk.java.net/~asmotrak/8079140/webrev.00/
>>
>> Artem



More information about the security-dev mailing list