[9] RFR:JDK-8076359:Test Task: Develop new tests for Leverage CPU Instructions for GHASH and RSA

[Anthony Scarpino]

On 11/03/2015 05:55 PM, Tim Du wrote:
> Hi All:
>
> Please help to review testing Preferred provider configuration feature
> for JCE .
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8076359
> https://bugs.openjdk.java.net/browse/JDK-8133151
> webrev: http://cr.openjdk.java.net/~fyuan/tim/8076359/webrev.00/
>
> Thank you very much.
>
> Regards
> Tim

Thanks for the work Tim, your tests cover pretty much everything..  I've 
got a few comments, mostly just add-ons or clarifications.


1) I think the best directory for these tests would be
test/sun/security/jca/.  The jca directory doesn't exist yet, so these 
would be the first tests.  My main code change was in ProviderList.java 
which is under the java.base module in sun/security/jca/.


2) In SecurityPropertyNegativeTest.java:afterJCESet(), if I understand 
the comment and code correctly, I think you want the comment to say:
/* Test that the setting of the security property after
    Cipher.getInstance() does not influence previously
    loaded instances */


3) I think it is valuable to have the failures exceptions to print the 
expected provider and the provider that was returned.  For example:

   Test Failed: Get wrong provider from Solaris sparcv9 platform
   Expected provider: SunJCE, Returned provider: OracleUcrypto.


4) In SolarisProviderTest.java, could you add an algorithm test after 
line 93?  I think it is useful to verify an algorithm that is not in the 
preferred list is not being redirected.  For example:

   MessageDigest md = MessageDigest.getInstance("MD5");
   if (!md.getProvider().getName().equals("OracleUcrypto")) {
       throw new RuntimeException(...);
   }


thanks

Tony