[9] RFR: 8048356: SecureRandom default provider tests

[Rajan Halade]

Thanks for the comments, Brad. I have addressed those here -

http://cr.openjdk.java.net/~rhalade/8048356/webrev.01/

I plan to have this test to check for default provider only so 
SecureRandom.getInstance(algorithm, provider) API is not good fit here. 
I think there are other tests which use this API and provide sufficient 
coverage.

Thanks,
Rajan
On 11/9/15 1:54 PM, Bradford Wetmore wrote:
>
>
> On 9/4/2015 1:43 PM, Rajan Halade wrote:
>> Please help with your review of this new test to check default provider
>> used with SecureRandom.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8048356
>> Webrev: http://cr.openjdk.java.net/~rhalade/8048356/webrev.00/
>
> 51:  Minor nit, you might reverse the order to match line 47.
>
>     ... if (!provider.equals("SUN"))...
>
> I would suggest also doing a test with the specified provider.
>
>     SecureRandom instance =
>         SecureRandom.getInstance(algorithm, provider);
>
> 70:  For readability, you might also reset provider here, or at least 
> provide a comment.
>
> Otherwise, looks ok.
>
> Brad