RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

[Langer, Christoph]

Hi Max,

thanks for your hint. I now implemented a dummy provider that would recreate the issue.

Also thanks for the hint regarding the @requires tag. I implemented that and I also reworked all the other testcases for sunmscapi to make use of @requires and threw out unnecessary checks for MSCAPI availability.

Is that ok now?

Best regards
Christoph

-----Original Message-----
From: Wang Weijun [mailto:weijun.wang at oracle.com] 
Sent: Freitag, 13. November 2015 02:08
To: Langer, Christoph <christoph.langer at sap.com>
Cc: Vincent Ryan <vincent.x.ryan at oracle.com>; security-dev at openjdk.java.net
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data


> On Nov 13, 2015, at 7:12 AM, Langer, Christoph <christoph.langer at sap.com> wrote:
> 
> Hi Vincent,
>  
> I just updated the changeset with a testcase:http://cr.openjdk.java.net/~clanger/webrevs/8139436.3/
>  
> The testcase would run through with or without my patch, unless you specify the IAIK provider as explained in the test description.

Maybe you can add a simple provider inside the test that mimics the behavior of IAIK's certificate factory? Or just fail immediately?

Otherwise few people will run the test like you described, it becomes practically @manual.

--Max

>  
> Can the fix be pushed now?
>  
> Thanks
> Christoph