RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

[Langer, Christoph]

OK, thanks for reviewing.

Please push the fix at your convenience.

Any objections against downporting to JDK 8?

-----Original Message-----
From: Vincent Ryan [mailto:vincent.x.ryan at oracle.com] 
Sent: Montag, 16. November 2015 08:20
To: Wang Weijun <weijun.wang at oracle.com>
Cc: Langer, Christoph <christoph.langer at sap.com>; security-dev at openjdk.java.net
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

Yes the source changes look fine.
Last week I ran the tests using webrev.4 and all passed.

Thanks Christoph for the comprehensive fix.


> On 16 Nov 2015, at 00:32, Wang Weijun <weijun.wang at oracle.com> wrote:
> 
> All tests look fine.
> 
> I suppose Vincent already agreed with the src change. Right?
> 
> For safety, I am running all related tests on windows-i586 and windows-x64 now.
> 
> Thanks
> Max
> 
>> On 2015年11月16日, at 上午7:27, Langer, Christoph <christoph.langer at sap.com> wrote:
>> 
>> Hi Max,
>> 
>> thanks for that hint about correctly referencing the inner class. Now I could do it.
>> 
>> As for PrngSlow.java: By having a closer look, I discovered that the test was always running into an exception, as the algorithm name "PRNG" is not available for MSCAPI. I renamed it to the correct value of "Windows-PRNG" and now the test would run. I also cleaned the class and removed the exception handler so real exceptions should pop up now.
>> 
>> Also, I completed adding the @requires tag for each test.
>> 
>> This is the result: http://cr.openjdk.java.net/~clanger/webrevs/8139436.6/
>> 
>> Best regards
>> Christoph
>