RFR 8143377: Test PKCS8Test.java fails

Wang Weijun weijun.wang at oracle.com
Wed Nov 25 01:44:00 UTC 2015


Done. http://hg.openjdk.java.net/jdk9/dev/jdk/rev/33fd40487d6d

Thanks
Max

> On Nov 25, 2015, at 7:42 AM, Rajan Halade <rajan.halade at oracle.com> wrote:
> 
> Looks good to me, thanks for the updates!
> 
> Please wait for one official reviewer before you commit.
> 
> Thanks,
> Rajan
> On 11/24/15 3:36 PM, Amanda Jiang wrote:
>> Hi Rajan,
>> 
>> Thanks for reviewing, please check the updated changeset:
>> 
>> http://cr.openjdk.java.net/~amjiang/8143377/webrev.01/
>> 
>> 
>> Thanks,
>> Amanda
>> 
>> On 15/11/24 下午3:26, Rajan Halade wrote:
>>> This test was added to ProblemList.txt, please update it to remove the test.
>>> 
>>> - sun/security/pkcs/pkcs8/PKCS8Test.java solaris-all
>>> 
>>> Thanks,
>>> Rajan
>>> 
>>> On 11/24/15 3:13 PM, Rajan Halade wrote:
>>>> Hi Amanda,
>>>> 
>>>> If you want skip test on solaris, please use -
>>>> 
>>>> @requires (os.family != "solaris")
>>>> 
>>>> http://openjdk.java.net/jtreg/tag-spec.html#requires_names
>>>> 
>>>> Note: I am not a official OpenJDK reviewer.
>>>> 
>>>> Thanks,
>>>> Rajan
>>>> 
>>>> On 11/24/15 2:05 PM, Amanda Jiang wrote:
>>>>> Hi Max,
>>>>> 
>>>>> Could you please review the fixes below for a test bug?
>>>>> 
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8143377
>>>>> Webrev: http://cr.openjdk.java.net/~amjiang/8143377/webrev/
>>>>> 
>>>>> Thanks,
>>>>> Amanda
>>>> 
>>> 
>> 
> 




More information about the security-dev mailing list