RFR 8141690: JDK-8133151 change to MakeJavaSecurity.java is not complete

Sean Mullan sean.mullan at oracle.com
Wed Nov 25 15:04:36 UTC 2015


The fix looks fine to me. For testing, can you create a test that uses a 
custom java.security file with "#ifndef solaris-sparc" in it, and check 
whether the property is used or not depending on what system is being 
tested?

--Sean

On 11/24/2015 06:10 AM, Magnus Ihse Bursie wrote:
> On 2015-11-20 02:12, Wang Weijun wrote:
>> Ding dong.
> Even though this code resides in the make directory, it is not really
> build code, so I cannot comment on it.
>
> /Magnus
>
>>
>>> On Nov 9, 2015, at 3:35 PM, Wang Weijun <weijun.wang at oracle.com> wrote:
>>>
>>> Hi All
>>>
>>> Please review the code change at
>>>
>>>    http://cr.openjdk.java.net/~weijun/8141690/webrev.00/
>>>
>>> JDK-8133151 added support for "#ifdef solaris-sparc" but not "#ifndef
>>> solaris-spare". This is fixed and I also added "#else".
>>>
>>> How do I test the change?
>>>
>>> Thanks
>>> Max
>>>
>



More information about the security-dev mailing list