RFR : 8133535: Better exception messaging in Ucrypto code

Seán Coffey sean.coffey at oracle.com
Tue Sep 8 09:48:19 UTC 2015


On 08/09/2015 10:42, Ivan Gerasimov wrote:
> Thanks, Seán!
>
> On 08.09.2015 11:00, Seán Coffey wrote:
>> With recent changes from (JDK-8132082) affecting the same ucrypto 
>> code, I've re-based my patch. Here's the new webrev :
>>
>> http://cr.openjdk.java.net/~coffeys/webrev.8133535.jdk9.v2/webrev/
>>
> This looks very useful.
>
> NativeCipher.java:
>  283                              ("Wrong IV length: must be " + 
> blockSize +
>  284                               " bytes long");
> Would it make sense to include the actual length of the vector?
Yes - good catch Ivan. Will include that value.
>
> In a couple of places (e.g. NativeKey.java, line #146) the indentation 
> isn't consistent.
Good point, I'll run through indentation again before final push.

Thanks,
Sean.
>
> Otherwise looks good to me!
>
> Sincerely yours,
> Ivan
>
>> Regards,
>> Sean.
>>
>> On 24/08/2015 13:54, Seán Coffey wrote:
>>> Hoping to improve some of the exception messaging that is thrown 
>>> from Ucrypto code. I'm hoping to tackle other components in the 
>>> security libraries on a case by case basis. Aim is to improve 
>>> exception messages and capture detail for end user where possible.
>>>
>>> bug report : https://bugs.openjdk.java.net/browse/JDK-8133535
>>> webrev : 
>>> http://cr.openjdk.java.net/~coffeys/webrev.8133535.jdk9/webrev/
>>>
>>
>>
>



More information about the security-dev mailing list