RFR 8056174: New APIs for jar signing
Mandy Chung
mandy.chung at oracle.com
Wed Sep 30 02:46:56 UTC 2015
> On Sep 28, 2015, at 4:34 PM, Weijun Wang <weijun.wang at oracle.com> wrote:
>
>>
>> Function: are you missing an @modules tag for the jarsigner module?
>
> Which one? I thought @modules is only used if you want to call non-exported classes.
@modules can also be used to specify which modules this test requires that will be used for future test selection feature e.g. when running on an image with only specific modules but not all.
For test/sun/security/tools/jarsigner/newapi/Function.java, you can add @modules jdk.jartool.
BTW, the new tests should be under jdk/test/jdk/security/jarsigner directory following the existing convention (I guess Options.java should be test/sun/security/tools/jarsigner/Options.java).
Instead of using sun.tools.jar.Main, can you use the test library (see jdk/test/lib/testlibrary/jdk/testlibrary/JarUtils.java)?
Mandy
More information about the security-dev
mailing list