RFR 8153545: sun/security/pkcs11/Provider/Login.sh fails on Linux

[Amanda Jiang]

Hi Max,

Please see details in line.

On 16/4/9 上午1:46, Wang Weijun wrote:
> Hi Amanda,
>
> This is better.
>
> On the other hand, I read the bug report and am not sure if this is the correct way to fix it. Maybe the ("java.security.SecurityPermission" "putProviderProperty.SunDeploy-MozillaJSS") permission should be granted?
SecurityPermission "putProviderProperty.*" is granted in the policy 
files(Login.policy and Basic.policy), and those policy files are parsed 
to PKCS11Test class as arguments.  Please check details in Artem's reply 
to this email thread.
> Or maybe this is a source bug? Artem reported that the problem is only on linux-x86. It's better we get a consistent behavior across platforms.
This bug is not only happened on Linux-x86, at least we found same 
failures on Linux-x86, Linux-x64 and MacOSX so far.
More reported failures are recorded at bug : 
https://bugs.openjdk.java.net/browse/JDK-8153545
I will submit a JPRT run with latest 9-dev repo and my changesset, to 
make sure this fix will work on all platform.

Thanks,
Amanda
>
> Thanks,
> Max
>
>> On Apr 9, 2016, at 8:20 AM, Amanda Jiang <amanda.jiang at oracle.com> wrote:
>>
>> Hi Max,
>>
>> Thanks for reviewing, you are right, "sm" should be the correct argument.
>> I updated the test argument and PKCS11Test, please check the new webrev:
>> http://cr.openjdk.java.net/~amjiang/8153545/webrev.02/
>>
>> Thanks,
>> Amanda
>>
>> On 16/4/8 上午12:28, Wang Weijun wrote:
>>> Hi Amanda
>>>
>>> I am not familiar with the tests, but it looks like the 1st args argument should be "sm" [1] to enable the security manager, not "true".
>>>
>>> If PKCS11Test always uses args as command and optional argument(s), maybe you should throw an exception if the command is unknown.
>>>
>>> Thanks
>>> Max
>>>
>>> [1] http://hg.openjdk.java.net/jdk9/dev/jdk/file/cac52c9da800/test/sun/security/pkcs11/PKCS11Test.java#l184
>>>
>>>
>>>> On Apr 8, 2016, at 1:09 PM, Amanda Jiang <amanda.jiang at oracle.com> wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Please help to review following changeset which fixes test bug for sun/security/pkcs11/Provider/Login.sh and another similar failed test.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8153545
>>>> Changest: http://cr.openjdk.java.net/~amjiang/8153545/webrev.01/
>>>>
>>>> Thanks,
>>>> Amanda