RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

[Xuelei Fan]

On 8/25/2016 11:17 AM, Artem Smotrakov wrote:
> Hi Xuelei,
>
> Yes, I know that JSSE provider initializes only once. But I suppose that tests which use default JSSE configuration (like this test) can be safely run in agent VM. Am I missing something?
>
The default one can be customized.  For example, the protocols, cipher 
suites, etc.  So it is not safe to run in agentvm/samevm mode.

Xuelei

> Artem
>
> ----- Original Message -----
> From: xuelei.fan at oracle.com
> To: artem.smotrakov at oracle.com, security-dev at openjdk.java.net
> Cc: svetlana.nikandrova at oracle.com
> Sent: Wednesday, August 24, 2016 7:21:55 PM GMT -08:00 US/Canada Pacific
> Subject: Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"
>
> On 8/25/2016 9:27 AM, Artem Smotrakov wrote:
>>> BTW, please run the test in othervm mode.
>> Why do you think it's necessary here? I don't see the test modifies
>> anything that may affect other tests running in the same JVM (for
>> example, system properties). Am I missing something?
> It's not about the test code, but about the JSSE impl.  The JSSE impl
> uses a lot of singleton static fields for performance.  Once these
> fields are initialized, they may impact other test cases.
>
> In JSSE test cases, we always run in othervm mode, and put a comment
> like (See test/javax/net/ssl/templates/SSLSocketTemplate.java):
>
> // SunJSSE does not support dynamic system properties, no way to re-use
> // system properties in samevm/agentvm mode.
>
>
> Xuelei
>