RFR[9] JDK-8170523: Some PKCS11 test cases are ignored with security manager

Sean Mullan sean.mullan at oracle.com
Fri Dec 2 21:02:08 UTC 2016


Hi John,

I don't think we should modify the test to disable a SecurityManager and 
then reenable it to avoid a security check -- that seems like a pattern 
we should avoid. Have you tried to reorganize this code so that this 
setup is done before you initially enable the SecurityManager?

Thanks,
Sean

On 12/1/16 10:32 PM, John Jiang wrote:
> Hi,
> Some PKCS11 tests call PKCS11Test.getDistro(), which run command "uname
> -v", to determine the OS distro.
> But if the tests enable security manager and don't grant appropriate
> file permission, PKCS11Test.getDistro() fails to get the distro.
> Then, the associated cases will be ignored since the tests think that
> the OS is not the target.
>
> Webrev: http://cr.openjdk.java.net/~jjiang/8170523/webrev.00/
> Issue: https://bugs.openjdk.java.net/browse/JDK-8170523
>
> Best regards,
> John Jiang
>



More information about the security-dev mailing list