[PATCH] 8069128: remove deprecation warning suppression from KeychainStore

Sean Mullan sean.mullan at oracle.com
Fri Dec 9 18:04:20 UTC 2016


Looks good to me. Please add a noreg label (noreg-cleanup or 
noreg-trivial probably) to the bug.

--Sean

On 12/9/16 10:53 AM, Adam Petcher wrote:
>
> KeychainStore has a couple of @SuppressWarnings("deprecation")
> annotations that were required due to references to an overloaded equals
> method in ObjectIdentifier that was marked as deprecated. This method
> has since been removed, so these calls now resolve to a non-deprecated
> method.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8069128
>
> Diff:
>
> diff --git
> a/src/java.base/macosx/classes/apple/security/KeychainStore.java
> b/src/java.base/macosx/classes/apple/security/KeychainStore.java
> --- a/src/java.base/macosx/classes/apple/security/KeychainStore.java
> +++ b/src/java.base/macosx/classes/apple/security/KeychainStore.java
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights
> reserved.
> + * Copyright (c) 2011, 2016, Oracle and/or its affiliates. All rights
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -911,7 +911,6 @@
>          return true;
>      }
>
> -    @SuppressWarnings("deprecation")
>      private byte[] fetchPrivateKeyFromBag(byte[] privateKeyInfo) throws
> IOException, NoSuchAlgorithmException, CertificateException
>      {
>          byte[] returnValue = null;
> @@ -972,7 +971,6 @@
>          return returnValue;
>      }
>
> -    @SuppressWarnings("deprecation")
>      private byte[] extractKeyData(DerInputStream stream)
>          throws IOException, NoSuchAlgorithmException, CertificateException
>      {
>



More information about the security-dev mailing list