[9] RFR: 8166531: sun/security/ssl/SocketCreation/SocketCreation.java fails intermittently

[Artem Smotrakov]

Hi Xuelei,

I am not sure either, but I would like to try. If it doesn't work, we 
can go and re-write the test to follow SSLSocketTemplate. Actually, I 
don't think it is really possible because SSLSocketTemplate uses 
connect() method which is not used by the test.

Artem


On 12/15/2016 02:04 PM, Xuelei Fan wrote:
> I'm not sure this update would work.
>
> As this is a special test, it might be possible to copy/past and 
> update the template code (or old sample code) here as we did to use 
> the old template.
>
> Xuelei
>
> On 12/15/2016 11:23 AM, Artem Smotrakov wrote:
>> Hello,
>>
>> Please review the patch below for
>> sun/security/ssl/SocketCreation/SocketCreation.java test.
>>
>> The test has been observed to fail intermittently, but I couldn't
>> reproduce it by running the test in a loop. The test creates sockets for
>> TLS connection in different ways. Even if the test is very old, I
>> wouldn't like to change its original behavior. It might be better to use
>> SSLSocketTemplate here, but it would require a significant update to
>> SSLSocketTemplate, and splitting the test to 5 tests. Instead of this, I
>> am proposing to add some simple synchronization on client side where the
>> test was seen to fail. If it doesn't work, we can try to use
>> SSLSocketTemplate then.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8166531
>> Webrev: http://cr.openjdk.java.net/~asmotrak/8166531/webrev.00/
>>
>> Artem
>>