Code Review Request, JDK-8171337 Check for correct SSLEngineImpl/SSLSocketImpl.setSSLParameters handshaker update method

Xuelei Fan xuelei.fan at oracle.com
Tue Dec 20 00:39:43 UTC 2016


On 12/19/2016 12:20 PM, Bradford Wetmore wrote:
> For SSLSocket, there are other .started() methods with similar
> conditions, should those be changed as well?
>
The one in SSLSocketImpl is used to get the handshake application 
protocol (getHandshakeApplicationProtocol, line 2661-2664), better to 
use started() for the accuracy value for "handshake".

Thanks,
Xuelei

> Thanks,
>
> Brad
>
>
> On 12/16/2016 11:03 AM, Xuelei Fan wrote:
>> Hi Brad,
>>
>> Please review this handshake update method miss-use fix:
>>
>>    http://cr.openjdk.java.net/~xuelei/8171337/webrev.00/
>>
>> The activation process of handshake may consider the parameters in a big
>> picture and make adjustment accordingly.  Basically, SSL parameters
>> should be configured before the handshake activated.
>>
>> Thanks,
>> Xuelei



More information about the security-dev mailing list