RFR 8147772: Some KerberosTicket methods throw NPE after being destroyed

Wang Weijun weijun.wang at oracle.com
Mon Feb 15 02:43:31 UTC 2016


Webrev updated at

  http://cr.openjdk.java.net/~weijun/8147772/webrev.01/

with javadoc changes. Please review again.

Thanks
Max

> On Jan 20, 2016, at 10:22 PM, Wang Weijun <weijun.wang at oracle.com> wrote:
> 
> 
>> On Jan 20, 2016, at 10:18 PM, Sean Mullan <sean.mullan at oracle.com> wrote:
>> 
>> On 01/20/2016 09:13 AM, Wang Weijun wrote:
>>> 
>>>> On Jan 20, 2016, at 10:14 PM, Sean Mullan <sean.mullan at oracle.com> wrote:
>>>> 
>>>> On 01/20/2016 08:52 AM, Wang Weijun wrote:
>>>>> You mean let them throw an ISE after destroyed? Not sure if it is backportable.
>>>> 
>>>> No, I am just talking about documenting existing behavior, ex:
>>>> 
>>>> For these methods, I would add:
>>>> 
>>>> This method returns null if the ticket has been destroyed.
>>> 
>>> They don't return null, an NPE is thrown. So I have to fix it in some way.
>> 
>> Sorry, I meant to say "document the new behavior for the methods in this webrev and existing behavior for the other methods with respect to when the ticket has been destroyed."
> 
> I see. So you agree with my code changes but ask me to document them.
> 
> --Max
> 




More information about the security-dev mailing list