Code Review Request 8149417 Use final restricted flag

Seán Coffey sean.coffey at oracle.com
Thu Feb 18 08:16:59 UTC 2016


On 18/02/2016 02:09, Wang Weijun wrote:
> IMO a noreg-trivial is enough.
Why ?

Yes  -- the fix may be trivial but a testcase helps ensure that no 
engineer even reverts this field in the future without seeing this 
issue. Code goes through churning and people forget edits made in the 
past - esp. the trivial ones.

regards,
Sean.
>
> --Max
>
>> 在 2016年2月18日,09:28,Xuelei Fan <xuelei.fan at oracle.com> 写道:
>>
>> Hi,
>>
>> A new test case was added.  Please review the update:
>>
>>    http://cr.openjdk.java.net/~xuelei/8149417/webrev.01/
>>
>> Thanks,
>> Xuelei
>>
>>> On 2/15/2016 9:07 PM, Sean Mullan wrote:
>>> Looks good.
>>>
>>> --Sean
>>>
>>>> On 02/15/2016 01:33 AM, Xuelei Fan wrote:
>>>> Hi,
>>>>
>>>> Please review this code cleanup:
>>>>
>>>>    http://cr.openjdk.java.net/~xuelei/8149417/webrev.00/
>>>>
>>>> Simple fix, adding final key word to a static flag.
>>>>
>>>> Thanks,
>>>> Xuelei




More information about the security-dev mailing list