RFR 8146377: test/sun/security/tools/jarsigner/concise_jarsigner.sh failing

Wang Weijun weijun.wang at oracle.com
Mon Jan 4 08:21:36 UTC 2016


> On Jan 4, 2016, at 4:19 PM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
> An interesting bug.  Looks fine to me.

Yes, I could have closed it as "Not Reproducible" and wait for another 4 years to fix it.

--Max

> 
> Xuelei
> 
> On 1/1/2016 1:26 AM, Wang Weijun wrote:
>> Hi
>> 
>> Please review the fix of https://bugs.openjdk.java.net/browse/JDK-8146377. Some years have more days than 365 and the test fails. The fix is simply
>> 
>> diff --git a/test/sun/security/tools/jarsigner/concise_jarsigner.sh b/test/sun/security/tools/jarsigner/concise_jarsigner.sh
>> --- a/test/sun/security/tools/jarsigner/concise_jarsigner.sh
>> +++ b/test/sun/security/tools/jarsigner/concise_jarsigner.sh
>> @@ -69,8 +69,8 @@
>> # First part: output format
>> # ==========================================================
>> 
>> -$KT -genkeypair -alias a1 -dname CN=a1 -validity 365
>> -$KT -genkeypair -alias a2 -dname CN=a2 -validity 365
>> +$KT -genkeypair -alias a1 -dname CN=a1 -validity 366
>> +$KT -genkeypair -alias a2 -dname CN=a2 -validity 366
>> 
>> # a.jar includes 8 unsigned, 2 signed by a1 and a2, 2 signed by a3
>> $JAR cvf a.jar A1.class A2.class
>> 
>> Thanks
>> Max
>> 
> 




More information about the security-dev mailing list