Code Review Request JDK-8146725 Issues with SignatureAndHashAlgorithm.getSupportedAlgorithms

Wang Weijun weijun.wang at oracle.com
Sat Jan 9 00:49:52 UTC 2016


Looks fine.

Thanks
Max

> On Jan 9, 2016, at 8:44 AM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
> Hi,
> 
> Please review this simple fix for JDK-8146725.
> 
> In the SignatureAndHashAlgorithm.getSupportedAlgorithms() method, there
> is a synchronization block on a static final collection, priorityMap.
> The priorityMap would not get update any more after the instantiation.
> The synchronization is not actually necessary.
> 
> See the attack diff for the fix.  No new regression test.
> 
> Thanks,
> Xuelei
> <JDK-8146725.diff.txt>




More information about the security-dev mailing list