RFR: 8133085- Remove old style (pre-JDK 1.4) "new SunJCE()" provider calls in tests. Fails to compile.

[Bhanu Gopularam]

Hi all,

Please see the updated webrev:
http://cr.openjdk.java.net/~ntv/bhanu/8133085/webrev.01/

Changes: Reverted changes to tests running in FIPS mode and added 2016 to copyright.

Thanks,
Bhanu

-----Original Message-----
From: Bradford Wetmore 
Sent: Saturday, January 09, 2016 12:31 AM
To: Sean Mullan; Bhanu Gopularam; security-dev at openjdk.java.net
Subject: Re: RFR: 8133085- Remove old style (pre-JDK 1.4) "new SunJCE()" provider calls in tests. Fails to compile.

(Xuelei, see below)

Bhanu,

The proposed ClientJSSEServerJSSE.java/TrustManagerTest.java changes are incorrect.  These tests are setting JSSE into FIPS mode, so this test should be correct as is.

Brad



On 1/8/2016 8:34 AM, Sean Mullan wrote:
> Please update copyrights to include 2016. Otherwise, looks fine to me.
>
> --Sean
>
> On 01/08/2016 02:54 AM, Bhanu Gopularam wrote:
>> Hi all,
>>
>> Please review a fix for following bug:
>>
>> Bug Id -https://bugs.openjdk.java.net/browse/JDK-8133085
>>
>> Issue - Some security regression tests are directly instantiating the 
>> security providers instead of using the registered providers. Most of 
>> the cases the issue can be corrected by using registered security 
>> providers which are available during execution and instance need not 
>> be created.
>>
>> Solution - Refactored tests which are directly instantiating the 
>> security provider to use the registered ones. Fixes also include 
>> couple of tests which run on Solaris environment.
>>
>> ->sun/security/pkcs11/fips/TrustManagerTest.java
>>
>> ->sun/security/pkcs11/fips/ClientJSSEServerJSSE.java
>>
>> Webrev - http://cr.openjdk.java.net/~ntv/bhanu/8133085/webrev/
>>
>> Thanks,
>>
>> Bhanu
>>