RFR 8147772: Some KerberosTicket methods throw NPE after being destroyed

Sean Mullan sean.mullan at oracle.com
Wed Jan 20 14:18:37 UTC 2016


On 01/20/2016 09:13 AM, Wang Weijun wrote:
>
>> On Jan 20, 2016, at 10:14 PM, Sean Mullan <sean.mullan at oracle.com> wrote:
>>
>> On 01/20/2016 08:52 AM, Wang Weijun wrote:
>>> You mean let them throw an ISE after destroyed? Not sure if it is backportable.
>>
>> No, I am just talking about documenting existing behavior, ex:
>>
>> For these methods, I would add:
>>
>> This method returns null if the ticket has been destroyed.
>
> They don't return null, an NPE is thrown. So I have to fix it in some way.

Sorry, I meant to say "document the new behavior for the methods in this 
webrev and existing behavior for the other methods with respect to when 
the ticket has been destroyed."

--Sean

>
> --Max
>
>>
>> For other methods that already throw ISE, I would add:
>>
>> @throws IllegalStateException if the ticket has been destroyed
>>
>> --Sean
>>
>>>
>>> The problem is reported by customers using an old JRE.
>>>
>>> --Max
>>>
>>>> On Jan 20, 2016, at 9:36 PM, Sean Mullan <sean.mullan at oracle.com> wrote:
>>>>
>>>> On 01/19/2016 10:32 PM, Wang Weijun wrote:
>>>>> http://cr.openjdk.java.net/~weijun/8147772/webrev.00/
>>>>>
>>>>> No spec change, just safer return value.
>>>>
>>>> I think it would be useful to update the specification to indicate how these methods behave when the object has been destroyed. I also noticed that many of the methods do not declare that they throw IllegalStateException when destroyed, so I think a general cleanup of the specification would be a good thing to do as part of this issue for JDK 9.
>>>>
>>>> Thanks,
>>>> Sean
>>>
>


More information about the security-dev mailing list