RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

Alexandre (Shura) Iline alexandre.iline at oracle.com
Tue Jul 5 19:42:08 UTC 2016


This made sense, than you, Mandy.

Please review new version:
http://cr.openjdk.java.net/~shurailine/8158670/webrev.02/

Shura

> On Jul 2, 2016, at 3:26 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
>> On Jul 1, 2016, at 6:20 PM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
>> 
>> Please review the new version of the fix.
>> http://cr.openjdk.java.net/~shurailine/8158670/webrev.01/
> 
> This looks much better.  Small comment: you can use Layer::findModule and also Optional::ifPresent, like this:
> 
> boot.findModule("jdk.crypto.ucrypto”)
>    .ifPresent(m -> expected.add("com.oracle.security.ucrypto.UcryptoProvider”));
> 
> Mandy
> 



More information about the security-dev mailing list