[9] RFR: JDK-7052815 Change tests that remove or add providers to run in othervm mode

Tim Du tiantian.du at oracle.com
Thu Jul 7 09:11:41 UTC 2016


Hi Sean:

Thank you for reviewing the codes.
I updated the title for this bug and added othervm for the tests that 
add but not remove their own provider. Also corrected the typo. New 
webrev is available here: 
http://cr.openjdk.java.net/~tidu/7052815/webrev.01/ .
Please help to review it again.Thanks.

Regards
Tim
On 2016/7/6 23:05, Sean Mullan wrote:
> Could you add a more descriptive title for this bug report than 
> "Finish checking of 7052537"? How about "Change tests that remove 
> providers to run in othervm mode".
>
> Also, have you also checked if there are tests that just add their own 
> provider but don't remove it? This could also potentially cause 
> strange behavior if another test run in parallel accidentally uses 
> that provider (perhaps if it was inserted as the first provider and 
> implemented an algorithm that the test was testing).
>
> Typo in RemoveProviders.java:
>
> 28  * @run main/othrevm RemoveProviders
>
> s/othrevm/othervm/
>
> --Sean
>
> On 07/05/2016 08:11 AM, Tim Du wrote:
>> Hi ,
>>
>> Please help to review the path for "JDK-7052815 :Finish checking of
>> 7052537" .
>>
>> A few test are using removedProvider() to removed the security
>> provider,like JDK-7052537, If the tests not in othervm,it will affect
>> other tests. Checking tests which are using removedProvider() for
>> security area and update them run in othervm mode to avoid the same 
>> issue.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-7052815
>> webrev: http://cr.openjdk.java.net/~tidu/7052815/webrev.00/
>>
>> Regards
>> Tim




More information about the security-dev mailing list