RFR: 8160518: Semicolon is not recognized as comment starting character (Kerberos)
Ivan Gerasimov
ivan.gerasimov at oracle.com
Fri Jul 8 16:35:39 UTC 2016
Thank you Max for reviewing!
On 08.07.2016 3:41, Wang Weijun wrote:
> Change looks fine.
>
> Only one thing: why is the following @modules tag needed?
>
> java.security.jgss/sun.security.krb5.internal.crypto
It's a copy\paste error, I'll remove it before pushing.
With kind regards,
Ivan
> Thanks
> Max
>
>> On Jul 5, 2016, at 1:03 AM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
>>
>> Hello!
>>
>> We've got a complain that a semicolon character cannot be used to start a comment in the kerberos config file.
>> In the documentation [1] I don't see mentioning comments at all, but it is said that the config file is in style of Windows INI file, and the later does allow semicolons to be used.
>> This blog entry [2] also mentions the semicolon as an alternative to the hash sign '#'.
>>
>> Would you please review the trivial change?
>> Comments, suggestions are very welcome.
>>
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8160518
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8160518/00/webrev/
>>
>> [1] http://web.mit.edu/kerberos/krb5-1.13/doc/admin/conf_files/krb5_conf.html
>> [2] https://blogs.oracle.com/wangwj/entry/krb5_conf
>>
>> With kind regards,
>> Ivan
>>
>>
>
More information about the security-dev
mailing list