[9]RFR JDK-8160029: Security-libs tests need to avoid using jdk.testlibrary.Utils.getFreePort()

John Jiang sha.jiang at oracle.com
Sat Jul 9 07:18:14 UTC 2016


Hi Max,

On 2016/7/8 16:19, Wang Weijun wrote:
> The reason a loop is needed here is that both the TCT and UDP servers must listen on the same port number. With your fix, the TCP server finds a free port, but I doubt if it's free for the UDP server.
Yes, it's possible that the port still be occupied by another 
DatagramSocket.
Please review the updated webrev: 
http://cr.openjdk.java.net/~jjiang/8160029/webrev.01

Best regards,
John Jiang

>
> --Max
>
>
>> On Jul 8, 2016, at 2:35 PM, John Jiang <sha.jiang at oracle.com> wrote:
>>
>> Hi,
>> Would you like to review this patch for removing unnecessary usages on jdk.testlibrary.Utils.getFreePort() from security-libs tests?
>> In OpenJDK, I find only sun/security/krb5/auto/KDC.java should be modified for this issue.
>> If I miss something, please let me know.
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8160029
>> Webrev: http://cr.openjdk.java.net/~jjiang/8160029/webrev.00
>>
>> Thanks!
>>
>> John Jiang
>>
>>
>




More information about the security-dev mailing list