Code Review Request JDK-8161106 Improve SSLSocket test template

Xuelei Fan xuelei.fan at oracle.com
Mon Jul 11 05:16:37 UTC 2016


There is a nice catch of the timeout miss-match during the handling of
serverIsReady in doClientSide().   Here is the updated webrev:

    http://cr.openjdk.java.net/~xuelei/8161106/webrev.01/

Thanks,
Xuelei

On 7/11/2016 11:44 AM, Xuelei Fan wrote:
> Hi,
> 
> Please review this enhancement of SSLSocket test template:
>     http://cr.openjdk.java.net/~xuelei/8161106/webrev.00/
> 
> There are some known issues with the current SSLSocket test template
> (test/javax/net/ssl/templates/SSLSocketTemplate.java) in the automation
> testing environment:
> 1. the client or server can be blocked if the peer run into problems, as
> may result in intermittent timeout failure.
> 2. the server accepted connection may be not linked to the expected
> client. For example, some other test case may try to use and connect to
> a free server socket port, unfortunately this port can be actually
> opened by the server of SSLSocketTemplate because there is no
> synchronization about the free socket port between test cases.  It's OK
> to run the test singly, but may result in weird intermittent failure in
> the automation testing environment.
> 
> The new test template in this update considers the noises above.
> 
> Thanks,
> Xuelei
> 




More information about the security-dev mailing list