[9] RFR: 8151654: Additional modular test for "auth.login.defaultCallbackHandler" property

[Wang Weijun]

Why change C_BUILD_DIR to C_BLD_DIR everywhere?

Can you add the "-addmods m" option into the vmArgs parameter of the getJavaCommand() method? In fact, why must vmArgs be a map instead of a List<String>? Are you worried about the same system property be assigned twice?

There is no need to generate lists and convert it to array in getTestOutput(), just return what you need, like this:

  return new Object[][] {
      {1,2,3},
      {4,5,6},
  };

BTW, what's the main reason you rewrite existing tests?

Thanks
Max


> On Jul 15, 2016, at 1:01 AM, Sibabrata Sahoo <sibabrata.sahoo at oracle.com> wrote:
> 
> Hi,
>  
> Please review the following patch for “Additional modular test for "auth.login.defaultCallbackHandler" property”.
>  
> JBS: https://bugs.openjdk.java.net/browse/JDK-8151654
> Webrev: http://cr.openjdk.java.net/~ssahoo/8151654/webrev.00/
>  
> Description:
> A custom callback handler for JAAS can be provided through "auth.login.defaultCallbackHandler" security property. This patch provides test the behavior when the callback handler available in module/class path as modular/regular jar file.
> There are few minor changes over few existing test files due to missing “-addmods” during runtime for automated module dependency.
>  
> Thanks,
> Siba