RFR 8054536: sun.security.x509.Extension object may throw NPE for hashCode and equals method
Wang Weijun
weijun.wang at oracle.com
Mon Jul 25 15:17:58 UTC 2016
Hi Svetlana
> http://cr.openjdk.java.net/~snikandrova/8054536/webrev.03/ <http://cr.openjdk.java.net/%7Esnikandrova/8054536/webrev.03/>
Change looks fine.
One nit: we usually combine the null check and the assignment into a single line. For example, this.x = Objects.requireNonNull(x).
>
> BTW, should I rename bug and review? Current title seems to be irrelevant.
Yes, it's better.
Thanks
Max
>
> Thank you,
> Svetlana
>
More information about the security-dev
mailing list