[9] RFR:8160337 Remove intermittent key from sun/security/pkcs11/rsa/TestKeyPairGenerator.java

Xuelei Fan Xuelei.Fan at Oracle.Com
Tue Jul 26 08:29:47 UTC 2016


Looks fine to me.

Thanks,
Xuelei

> On Jul 23, 2016, at 1:30 AM, Rajan Halade <rajan.halade at oracle.com> wrote:
> 
> Looks good, thanks!
> 
> Note, I am not OpenJDK reviewer.
> 
> Thanks,
> Rajan
> 
>> On 7/21/16 11:48 PM, Tim Du wrote:
>> Thanks Rajan's comments,
>> Updated the code here: http://cr.openjdk.java.net/~tidu/8160337/webrev.01/ ,Please help to review it again.Thanks.
>> 
>> Regards
>> Tim
>>> On 2016/7/7 1:22, Rajan Halade wrote:
>>> Hi Tim,
>>> 
>>> Thanks for taking care of this one. Since the test is still using random data key "randomness" should be retained.
>>> 
>>> Thanks,
>>> Rajan
>>> 
>>>> On 7/6/16 1:04 AM, Tim Du wrote:
>>>> Hi All,
>>>> 
>>>> Would you help to review the path for "8160337:Remove intermittent key from sun/security/pkcs11/rsa/TestKeyPairGenerator.java"? JDK-8074580 has been fixed, @key intermittent can be removed.Thanks.
>>>> 
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8160337
>>>> webrev: http://cr.openjdk.java.net/~tidu/8160337/webrev.00/
>>>> 
>>>> Regards
>>>> Tim
> 




More information about the security-dev mailing list