RFR: 8157603 TestCipher.java doesn't check one of the decrypted message as expected
Valerie Peng
valerie.peng at oracle.com
Fri Jun 3 22:35:02 UTC 2016
Changes look fine.
Thanks,
Valerie
On 6/3/2016 8:57 AM, Artem Kosarev wrote:
>
> Could you please review the proposed fix for regression test
>
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8157603
> WEBREV: http://cr.openjdk.java.net/~akosarev/8157603/webrev.00
>
> DESCRIPTION:
> **Main problem is that we were not performing check that decryption
> into same buffer went correct.
> Instead, string created by decryption into another buffer was
> checked twice.
>
> Fix for the above issue was easy, but I also identified one more
> mistake:
> Initially, we were not calculating size of encrypted/decrypted
> messages when they were stored into the same buffer. After my fix
> their lengths will be calculated using values returned from /update /&
> /doFinal /methods.
>
> Moreover, I applied additional check on the length of
> crypted/decrypted messages.
>
>
> Changes were successfully tested by JPRT.
>
>
> Best regards,
> Artem Kosarev.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20160603/d4f893a7/attachment.htm>
More information about the security-dev
mailing list