RFR: 8155039: Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

Claes Redestad claes.redestad at oracle.com
Tue Jun 7 19:44:12 UTC 2016


Hi,

there is some lingering concern that this and related changes make it 
that much easier to accidentally leak the system Properties object 
outside of core modules. By wrapping access to the system Properties 
object in a class residing in a non-exported package we disallow this at 
little to no cost:

http://cr.openjdk.java.net/~redestad/8155039/webrev.02/

/Claes

On 2016-05-12 15:37, Claes Redestad wrote:
> Hi,
>
> the API this improvement depends on was updated to reflect more clearly
> that this
> is taking a privileged action:
> https://bugs.openjdk.java.net/browse/JDK-8155775
>
> Here's the updated webrev:
> http://cr.openjdk.java.net/~redestad/8155039/webrev.01/
>
> Thanks!
>
> /Claes
>
> On 2016-04-25 19:28, Claes Redestad wrote:
>> Hi,
>>
>> SSLContextImpl and TrustManagerFactoryImpl has some setup code that
>> could be
>> simplified, getting rid of a couple of anonymous classes in the process.
>>
>> Webrev: http://cr.openjdk.java.net/~redestad/8155039/webrev.00
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8155039
>>
>> Alternatively we could remove OpenFileInputStreamAction instead since
>> these two uses
>> introduced here are actually the only active uses of this old
>> convenience class.
>>
>> Thanks!
>>
>> /Claes
>



More information about the security-dev mailing list