RFR: 9: 8158569: ImpactOnSNI.java test failed with timeout
Rajan Halade
rajan.halade at oracle.com
Thu Jun 9 07:24:53 UTC 2016
You are right, I missed the fact that startClient has exception catch
which will allow test to call to serverThread.join(). Updated webrev
fixed this along with some more debug output.
Webrev: http://cr.openjdk.java.net/~rhalade/8158569/webrev.01/
Thanks,
Rajan
On 6/8/16 9:08 PM, Xuelei Fan wrote:
> I'm not sure this patch would work. What if throwing an exception
> immediately after the server ready in client side with/without this patch?
>
> There might be something wrong in the url connections of the testing.
> It might be worthy to add more defbug info for further evaluation.
>
> Xuelei
>
> On 6/9/2016 6:19 AM, Rajan Halade wrote:
>> Please help with your review of this patch. I was not able to reproduce
>> the timeout but thread dump indicates that test timed out on waiting for
>> server thread to join. Server thread is kept waiting on accept if client
>> doesn't connect.
>>
>> This patch allows test to throw exception, if any, on client or server
>> side eliminating this timeout scenario.
>>
>> Webrev: http://cr.openjdk.java.net/~rhalade/8158569/webrev.00/
>>
>> Thanks,
>> Rajan
More information about the security-dev
mailing list