[9] RFR 8157495: SHA-3 Hash algorithm performance improvements (~12x speedup)

Valerie Peng valerie.peng at oracle.com
Fri Jun 10 00:35:46 UTC 2016


Sure, I think it should be ok to skip the checks.
Webrev is updated at: http://cr.openjdk.java.net/~valeriep/8157495/webrev.01

I have removed the update on java.security file and we can address this 
later if needed.
Thanks for the review,
Valerie

On 6/9/2016 4:36 PM, Anthony Scarpino wrote:
> On 06/08/2016 10:28 AM, Valerie Peng wrote:
>> Tony,
>>
>> Can u please help reviewing this? Most if not all of the changes here
>> are performance enhancements suggestions from the performance team.
>> I polished them and then updated the java.security file to add SHA-3.
>>
>> Webrev: http://cr.openjdk.java.net/~valeriep/8157495/webrev.00/
>>
>> Thanks,
>> Valerie
>>
>
> One very minor nit at SHA3.java:132 and 148.  I'm not sure the WIDTH 
> checks are necessary since lanes and state are private and and have 
> predefined lengths.
>
> Otherwise I assume all the tests passed, producing the right output. 
> I'm fine with the change.   And as we talked offline, you can remove 
> the java.security change from the changeset.
>
> Tony
>


More information about the security-dev mailing list