RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules
Wang Weijun
weijun.wang at oracle.com
Thu Jun 16 01:33:08 UTC 2016
> On Jun 16, 2016, at 7:50 AM, Valerie Peng <valerie.peng at oracle.com> wrote:
>
> No big difference to me.
Good, I'll remove the cast.
@security-dev, can someone approve the whole webrev.05?
http://cr.openjdk.java.net/~weijun/8130302/webrev.05
Thanks
Max
> Valerie
>
> On 6/15/2016 8:40 AM, Wang Weijun wrote:
>>> On Jun 15, 2016, at 10:57 PM, Mandy Chung<mandy.chung at oracle.com> wrote:
>>>
>>>>> 241 throw (InvalidParameterException)
>>>>>
>>>>> This cast should not be needed?
>>>>>
>>>> } catch (UcryptoException ue) {
>>>> throw (InvalidParameterException)
>>>> new InvalidParameterException("Error using " + configArg).
>>>> initCause(ue.getCause());
>>>> }
>>>>
>>>> initCause() returns Throwable but the method's signature throws InvalidParameterException.
>>>>
>>> Perhaps have a local variable for InvalidParameterException exception.
>> Valerie, are you OK with this?
>>
>> --Max
>>
>>> Mandy
More information about the security-dev
mailing list