[9] review request 8151149: CipherSpi implementation of PBEWithSHA1AndDESede returns key size in bytes

Vincent Ryan vincent.x.ryan at oracle.com
Mon Mar 7 14:15:15 UTC 2016


Thanks Xuelei.

> On 7 Mar 2016, at 14:14, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
> On 3/7/2016 10:05 PM, Vincent Ryan wrote:
>> Please review this fix to PKCS#12 PBE CipherSpi classes to return the cipher key size in bits.
>> An effective key size of 112 bits is used for Triple DES.
>> Thanks.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8151149
>> Webrev: http://cr.openjdk.java.net/~vinnie/8151149/webrev.00/
>> 
> Nice!  Looks fine to me.
> 
> Thanks,
> Xuelei




More information about the security-dev mailing list