<Beans Dev> JDK 9 RFR of JDK-8151763; Use more informative format for problem list

Joseph D. Darcy joe.darcy at oracle.com
Thu Mar 31 00:06:40 UTC 2016


Hi Sergey,

The thinking is the reformatted file, with the bug on the same line as 
the test, will allow in the future better reporting and analysis of 
problem list entries with information from the bug database.

Thanks for the review; HTH,

-Joe

On 3/30/2016 5:02 PM, Sergey Bylokhov wrote:
> The fix looks fine to me. can you please clarify what "enabling better 
> reporting" from the bug description means? Where this information will 
> be reported?
>
> On 31.03.16 2:48, Joseph D. Darcy wrote:
>> Hi Mandy,
>>
>> Hopefully the third time will be the charm for this changeset after your
>> correction to the commented-out test:
>>
>>      http://cr.openjdk.java.net/~darcy/8151763.2
>>
>> I aligned the bug number in column 64 unless the test name took more
>> characters. (This isn't as evident in the webrev since the tab expansion
>> is different than in a text editor.)
>>
>> Thanks,
>>
>> -Joe
>>
>> On 3/29/2016 12:31 PM, Mandy Chung wrote:
>>>> On Mar 29, 2016, at 12:15 PM, joe darcy <joe.darcy at oracle.com> wrote:
>>>>
>>>> Hi Mandy,
>>>>
>>>> On 3/28/2016 8:48 PM, Mandy Chung wrote:
>>>>>> On Mar 28, 2016, at 5:03 PM, Joseph D. Darcy <joe.darcy at oracle.com>
>>>>>> wrote:
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> New iteration of the webrev updated after the Jigsaw integration
>>>>>> and incorporating the earlier feedback.
>>>>>>
>>>>>>     http://cr.openjdk.java.net/~darcy/8151763.1
>>>>>>
>>>>> # tools/jimage/JImageTest.java
>>>>> linux-i586,windows-i586
>>>>>
>>>>> Is this test accidentally removed?  Other than this, looks okay.
>>>> The "#" lines are comments so I was removing a commented out line. (I
>>>> assumed, but did not verify, the line for this test was a leftover
>>>> artifact of the recent Jigsaw merge.)
>>> I missed “#” since this test should be excluded (some error might have
>>> been creeped in before the integration)
>>>
>>> This test needs to be added back in the problem list.  I’ll create a
>>> changeset.
>>>
>>>>> Nit: it’d be good to have most of bug ids aligned in the same column
>>>>> start.
>>>>> Here are a few ones:
>>>>>
>>>>>   210 sun/security/krb5/auto/Unreachable.java     7164518 macosx-all
>>>>> no PortUnreachableException on Mac
>>>>>   212 java/security/KeyPairGenerator/SolarisShortDSA.java 7041639
>>>>> solaris-all Solaris DSA keypair generation bug
>>>>>   213 sun/security/tools/keytool/standard.sh 7041639
>>>>> solaris-all Solaris DSA keypair generation bug
>>>>>   346 java/util/Arrays/ParallelPrefix.java 8080165,8085982 
>>>>> generic-all
>>>>>   348 java/util/BitSet/BitSetStreamTest.java 8079538 generic-all
>>>>>   360 sun/tools/jmap/heapconfig/JMapHeapConfigTest.java
>>>>> 8072131,8132452 generic-all
>>>>>   370 sun/tools/jinfo/JInfoSanityTest.java
>>>>> 8059035 generic-all
>>>>>
>>>>>
>>>> I was trying to avoid introducing lots of spacing changes in an
>>>> attempt to make the patch easier to review, but I can look over these
>>>> cases again.
>>> That’d be good.  Thanks
>>> Mandy
>>
>
>




More information about the security-dev mailing list