Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

Wang Weijun weijun.wang at oracle.com
Tue May 10 06:37:17 UTC 2016


> On May 10, 2016, at 7:58 AM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
> On 5/10/2016 12:16 AM, Michael StJohns wrote:
>> You're going to hate me, but shouldn't this be checking the Provider
>> rather than the OS when trying to determine which test to ignore?
>> 
> It's more accurate to check the provider, too.
> 
> -   if (!System.getProperty("os.name").equals("SunOS")) {
> +   if (provider.getName().equals("SunPKCS11-Solaris") &&
> +         !System.getProperty("os.name").equals("SunOS")) {

There is SunPKCS11-Solaris not on SunOS?




More information about the security-dev mailing list