Code Review Request, 8154344 sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java fails on solaris

[Michael StJohns]

On 5/10/2016 2:37 AM, Wang Weijun wrote:
>> On May 10, 2016, at 7:58 AM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
>>
>> On 5/10/2016 12:16 AM, Michael StJohns wrote:
>>> You're going to hate me, but shouldn't this be checking the Provider
>>> rather than the OS when trying to determine which test to ignore?
>>>
>> It's more accurate to check the provider, too.
>>
>> -   if (!System.getProperty("os.name").equals("SunOS")) {
>> +   if (provider.getName().equals("SunPKCS11-Solaris") &&
>> +         !System.getProperty("os.name").equals("SunOS")) {
> There is SunPKCS11-Solaris not on SunOS?
>
There may be other Providers on SunOS besides the broken SunPKCS11...


Mike