RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

Rajan Halade rajan.halade at oracle.com
Thu May 19 22:18:33 UTC 2016


Hi Amanda,

I have following comments:
- UnsupportedProvider.java line 55: this assumes that it is okay to have 
NoSuchAlgorithmException for all providers.
- Update MessageDigest tests to use RandomFactory from 
http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/f8a3c1510f95/test/lib/testlibrary/jdk/testlibrary. 
It logs seed information which will be helpful to reproduce failure.
- Also, MessageDigest tests have no provider checks.

Rest of tests look fine to me. Note, I am not a official reviewer so 
please wait for official reviewer to integrate changes.

Thanks,
Rajan

On 5/19/16 11:34 AM, Amanda Jiang wrote:
> Hi All,
>
> Please help to review tests for JEP287: SHA-3 Hash Alogrithms.
>
> BugID: https://bugs.openjdk.java.net/browse/JDK-8156059
> Webrev: http://cr.openjdk.java.net/~amjiang/8156059/webrev.01/
> Test Plan: https://bugs.openjdk.java.net/browse/JDK-8068855
>
> Thanks,
> Amanda




More information about the security-dev mailing list