RFR 8157544: Typo in CtrDrbg::toString

Bradford Wetmore bradford.wetmore at oracle.com
Mon May 23 22:19:48 UTC 2016


+1

Brad


On 5/23/2016 1:53 AM, Xuelei Fan wrote:
> Looks fine to me.
>
> Xuelei
>
> On 5/23/2016 2:11 PM, Wang Weijun wrote:
>> Once upon a time securerandom.drbg.config looks like "Hash_DRBG/SHA-256" and it was changed to "Hash_DRBG,SHA-256" because "Hash_DRBG/SHA-512/224" is ambiguous.
>>
>> DRBG::toString follows this style, but I forgot to update one case.
>>
>> Now, it is fixed.
>>
>>      @Override
>>      public String toString() {
>> -        return super.toString() + "/"
>> +        return super.toString() + ","
>>                  + (usedf ? "use_df" : "no_df");
>>      }
>>
>> No webrev, just the patch above. Please take a review.
>>
>> Thanks
>> Max
>>
>



More information about the security-dev mailing list