RFR: 8158111: Make handling of 3rd party providers more stable

Xuelei Fan xuelei.fan at oracle.com
Mon May 30 09:14:38 UTC 2016


Looks fine to me.  Thanks!

Xuelei

On 5/30/2016 4:48 PM, Ivan Gerasimov wrote:
> Hello!
> 
> In the file
> src/java.base/share/classes/sun/security/ssl/RSAClientKeyExchange.java:
> 
> When doing the debug printing:
>                     System.out.println("The Cipher provider " +
>                         cipher.getProvider().getName() +
>                         " caused exception: " + iue.getMessage());
> 
> cipher.getProvider() may throw an exception, which will cause the
> fail-over branch get skipped.
> 
> 
> Furthermore, in the fail-over branch it is better to re-acquire an
> instance of the cipher, as the previous call to init() might have left
> the current instance in inconsistent state.
> 
> Would you please help review the proposed fix?
> 
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8158111
> WEBREV: http://cr.openjdk.java.net/~igerasim/8158111/00/webrev/
> 
> 
> With kind regards,
> Ivan
> 
> 




More information about the security-dev mailing list