Code Review Reqeust, JDK-8169362, Interop automated testing with Chrome

Xuelei Fan xuelei.fan at oracle.com
Thu Nov 10 03:02:21 UTC 2016


Thanks for review.  I will go ahead and push the changeset.  The latest 
update is:
     http://cr.openjdk.java.net/~xuelei/8169362/webrev.01/

Xuelei

On 11/10/2016 9:41 AM, Bradford Wetmore wrote:
> Hi Xuelei,
>
> Nothing major, mostly nits and some Netbeans suggestions.
>
> On 11/9/2016 5:17 AM, Xuelei Fan wrote:
>> Hi,
>>
>> Please review this test enhancement:
>>
>>    http://cr.openjdk.java.net/~xuelei/8169362/webrev.00/
>>
>> This update adds a interop new test case with Chrome ClientHello message.
>
> ClientHelloInterOp.java
> =======================
> 34:  import not needed.
>
> 43/92/138/178:  could be final.
>
> 265:  is value of null is never used.
>
> 290:  Generally prefer () groupings if you can.
>
> 316:  Nit, you could combine:
>
>     Certificate[] chain = new Certificate [] { keyCert };
>
> 200/211/285:  jcheck problems.
>
> You could make a lot of these methods/fields private unless you plan to
> use them later.
>
>
> ClientHelloChromeInterOp.java
> =============================
> 37:  import not needed.
>
> 46:  could be final.
>
> I didn't check the format of the ClientHello, assuming it does what you
> need.  Do you need me to do a secondary check?
>
> Ok otherwise,
>
> Brad
>
>



More information about the security-dev mailing list