RFR 8043252: Debug of access control is obfuscated - NullPointerException in ProtectionDomain

[Wang Weijun]

> On Nov 16, 2016, at 12:40 PM, Jamil Nimeh <jamil.j.nimeh at oracle.com> wrote:
> 
> Oops, good catch. I'll fix that.  I assume you don't need a third review for that?

No. Just push your change.

--Max

> 
> 
> 
> --Jamil
> 
> -------- Original message --------
> From: Wang Weijun <weijun.wang at oracle.com>
> Date: 11/15/16 7:48 PM (GMT-08:00)
> To: Jamil Nimeh <jamil.j.nimeh at oracle.com>
> Cc: security-dev at openjdk.java.net
> Subject: Re: RFR 8043252: Debug of access control is obfuscated - NullPointerException in ProtectionDomain
> 
> Looks fine.
> 
> Small nit: new test has copyright 2003, 2016.
> 
> --Max
> 
> > On Nov 16, 2016, at 11:45 AM, Jamil Nimeh <jamil.j.nimeh at oracle.com> wrote:
> > 
> > Good suggestions, thanks.
> > 
> > Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8043252/webrev.02
> > 
> > --Jamil
> > 
> > 
> > On 11/15/2016 06:18 PM, Wang Weijun wrote:
> >> 41         System.setSecurityManager(new SecurityManager());
> >> 
> >> This is strange. I suppose you only want to trigger a permission check?
> >> 
> >> If so, just change it to Policy.getPolicy(), and you can clean up the policy file a little.
> >> 
> >> Thanks
> >> Max
> >> 
> >>> On Nov 16, 2016, at 8:36 AM, Jamil Nimeh <jamil.j.nimeh at oracle.com> wrote:
> >>> 
> >>> Hello all,
> >>> 
> >>> This fixes an issue in ProtectionDomain, where Permission classes that take a loose interpretation of the getActions() method and return null cause an NPE to be thrown when a ProtectionDomain's toString method is called (during debugging for instance).
> >>> 
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8043252
> >>> Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8043252/webrev.01/
> >>> 
> >>> Thanks,
> >>> --Jamil
> > 
>