RFR[9] JDK-8168064: sun/security/ssl/ServerHandshaker/AnonCipherWithWantClientAuth.java failed with "Received fatal alert: handshake_failure"
Artem Smotrakov
artem.smotrakov at oracle.com
Wed Oct 26 20:02:09 UTC 2016
Hi John,
Looks good to me, thank you for the update.
Artem
On 10/26/2016 04:45 AM, John Jiang wrote:
> Hi Artem,
> Please take a look at this version:
> http://cr.openjdk.java.net/~jjiang/8168064/webrev.02/
> It set a new Server peer.
>
> Best regards,
> John Jiang
>
> On 2016/10/25 1:33, Artem Smotrakov wrote:
>> Hi John,
>>
>> I think it is too late to set parameters for server socket in
>> setServerApplication() because handshaking is already done at this
>> point.
>>
>> You can use setServerPeer() and setClientPeer() if you need to
>> configure server socket. In this case, you need to follow
>> SSLSocketSample.java to implement doServerSide().
>>
>> Artem
>>
>>
>> On 10/24/2016 03:24 AM, John Jiang wrote:
>>> Hi Artem,
>>> Thanks for your review.
>>> Would you like take a look at the updated webrev:
>>> http://cr.openjdk.java.net/~jjiang/8168064/webrev.01/
>>> I also modified SSLTest.java a bit to expose SSLServerSocket
>>> instance to support the fixing.
>>>
>>> Best regards,
>>> John Jiang
>>>
>>>
>>> On 2016/10/22 1:50, Artem Smotrakov wrote:
>>>> Hi John,
>>>>
>>>> It may be better to use SSLTest.java to avoid duplicate code. The
>>>> class basically contains parts of SSLSocketSample.java
>>>>
>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/file/0fb9ba19a63a/test/javax/net/ssl/templates/SSLTest.java
>>>>
>>>>
>>>> Here is an example
>>>>
>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/file/0fb9ba19a63a/test/sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java
>>>>
>>>>
>>>> Artem
>>>>
>>>>
>>>> On 10/20/2016 10:13 PM, John Jiang wrote:
>>>>> Hi,
>>>>> Please review this patch for fixing an intermittent issue on test
>>>>> sun/security/ssl/ServerHandshaker/AnonCipherWithWantClientAuth.java.
>>>>> The fix applies the pattern from
>>>>> test/javax/net/ssl/templates/SSLSocketSample.java
>>>>>
>>>>> Webrev: http://cr.openjdk.java.net/~jjiang/8168064/webrev.00/
>>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8168064
>>>>>
>>>>> Best regards,
>>>>> John Jiang
>>>>>
>>>>
>>>>
>>>
>>
>>
>
More information about the security-dev
mailing list