RFR: JDK-8186160 Fix a11y issues in java.security package

Brent Christian brent.christian at oracle.com
Mon Aug 14 17:02:36 UTC 2017


Hi, Max

This tag snuck in by mistake.  Before pushing the fix for JDK-8029891, 
we looked into ways to avoid addition of JavaDoc for all the
trivial method overrides.  I tried adding @hidden tags,
but they didn't do what we wanted, so they were taken out.  Except one - 
sorry about that.

-Brent

On 8/14/17 3:36 AM, Weijun Wang wrote:
>>
>> FWIW, there is one remaining issue to be addressed: it is a broken link in Provider.html.
>> It comes from Provider.replace(Object, Object, Object) which overrides
>> Properties.replace(Object, Object, Object), but for some reason, that method is
>> marked @hidden in Properties, causing a broken link in Provider. That needs
>> to be investigated, but I don't want to block these accessibility fixes.
> 
> I don't understand why there is a @hidden in Properties.java. There are many other methods nearby with a similar structure and I cannot see how this one is different.
> 
> The tag was added at
> 
>     http://hg.openjdk.java.net/jdk9/dev/jdk/rev/01a8615439f0#l2.349
> 
> in the fix for
> 
>     8029891 : Deadlock detected in java/lang/ClassLoader/deadlock/GetResource.java
> 
> +
> +    /** @hidden */
> +    @Override
> +    public synchronized boolean replace(Object key, Object oldValue, Object newValue) {
> +        return map.replace(key, oldValue, newValue);
> +    }
> 
> *Brent*: Is this method any special?
> 
> Thanks
> Max
> 
>>
>> -- Jon
> 
> 



More information about the security-dev mailing list