RFR 8192987: keytool should remember real storetype if it is not provided

Weijun Wang weijun.wang at oracle.com
Thu Dec 7 08:53:15 UTC 2017


Hi All

Please take a look at

   http://cr.openjdk.java.net/~weijun/8192987/webrev.00/

The fix delays the assignment of storetype and srcstoretype (when they are not provided on the command line) to where the actual keystore file is loaded.

I could have retained lines 711-719 because we had hasStoretypeOption and hasSrcStoretypeOption flags indicating whether they are provided by the user or set on those lines, but leaving them to be null as long as possible helps exposing any unintended usages. Now they are only used in pkcs11 and MSCAPI type checks which are null safe, and hasStoretypeOption and hasSrcStoretypeOption are now useless and removed.

Thanks
Max




More information about the security-dev mailing list