RFR: 8174837: Add "since=9" to deprecated ContentSigner and ContentSignerParameters classes

Vincent Ryan vincent.x.ryan at oracle.com
Mon Feb 13 16:28:08 UTC 2017


Your fix looks fine. Minor nit with the copyright header in ContentSigner.java: it’s missing a comma after ‘2017’.
Thanks.


> On 13 Feb 2017, at 16:25, Sean Mullan <sean.mullan at oracle.com> wrote:
> 
> Could I get a quick code review for this simple fix for https://bugs.openjdk.java.net/browse/JDK-8174837?:
> 
> diff --git a/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSigner.java b/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSigner.java
> --- a/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSigner.java
> +++ b/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSigner.java
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2015, 2017 Oracle and/or its affiliates. All rights reserved.
>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  *
>  * This code is free software; you can redistribute it and/or modify it
> @@ -38,7 +38,7 @@
>  * @deprecated This class has been deprecated.
>  */
> 
> - at Deprecated
> + at Deprecated(since="9")
> public abstract class ContentSigner {
> 
>     /**
> diff --git a/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSignerParameters.java b/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSignerParameters.java
> --- a/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSignerParameters.java
> +++ b/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSignerParameters.java
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2003, 2015, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2003, 2017, Oracle and/or its affiliates. All rights reserved.
>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  *
>  * This code is free software; you can redistribute it and/or modify it
> @@ -36,7 +36,7 @@
>  * @author Vincent Ryan
>  * @deprecated This class has been deprecated.
>  */
> - at Deprecated
> + at Deprecated(since="9")
> public interface ContentSignerParameters {



More information about the security-dev mailing list