RFR 8172975: SecurityTools.keytool() needs to accept user input

Weijun Wang weijun.wang at oracle.com
Fri Jan 20 12:18:11 UTC 2017


Thanks. All suggestions accepted. Will push after updated.

--Max

On 01/20/2017 08:01 PM, Artem Smotrakov wrote:
> It might be better to remove the response file in a finally block.
> Main.java needs new copyright year.
>
> Otherwise, looks fine.
>
> I see you removed public sign() and verify() methods in SecurityTools,
> please make sure that they are not used by other tests.
>
> Artem
>
>
> On 01/20/2017 02:44 PM, Weijun Wang wrote:
>> Updated
>>
>> http://cr.openjdk.java.net/~weijun/8172975/root/webrev.01/
>> http://cr.openjdk.java.net/~weijun/8172975/webrev.01/
>>
>> I'll need this in my other work.
>>
>> Thanks
>> Max
>>
>> On 01/20/2017 07:23 PM, Artem Smotrakov wrote:
>>> It's up to you. You can change it now if you have time, or we can do it
>>> once we need to update jarsigner tests.
>>>
>>> Artem
>>
>


More information about the security-dev mailing list