Review Request: JDK-8173024 Replace direct use of AuthResources resource bundle from jdk.security.auth
Weijun Wang
weijun.wang at oracle.com
Sun Jan 22 01:02:46 UTC 2017
Why isn't the new getAuthResourceString() using
AccessController.doPrivileged anymore?
Thanks
Max
On 01/22/2017 05:55 AM, Mandy Chung wrote:
> Since AuthResources is the only altBundle, Max suggests to replace getString(String, String) with a method for AuthResources bundle specifically. It’s an alternative I considered too. Here is the revised webrev:
>
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173024/webrev.01/
>
> Mandy
>
>> On Jan 18, 2017, at 8:10 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>
>> Webrev at:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173024/webrev.00/
>>
>> sun.security.util.ResourcesMgr::getString(String s, String altBundleName) is one existing mechanism to get the localized string from AuthResources and have sun.security.util.AuthResources resource bundle encapsulated in java.base.
>>
>> jdk.security.auth loads “sun.security.util.AuthResources” resource bundle in some place and uses ResourcesMgr::getString as well.
>>
>> This patch replaces direct loading of AuthResources resource bundle from jdk.security.auth so that jdk.security.auth does not need to access the resource bundle directly.
>>
>> I ran all core tests.
>>
>> Mandy
>
More information about the security-dev
mailing list